Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: drop call to xml_set_object() #851

Merged
merged 1 commit into from
Nov 2, 2023
Merged

refactor: drop call to xml_set_object() #851

merged 1 commit into from
Nov 2, 2023

Conversation

Girgias
Copy link
Contributor

@Girgias Girgias commented Oct 7, 2023

The xml_set_X_handler() functions already pass in standard callables.

Related to php/php-src#12340

@jtojnar
Copy link
Contributor

jtojnar commented Oct 8, 2023

Hmm, if I it is only used for xml_set_X_handler, it should indeed not be needed since f5c99dd

@Girgias
Copy link
Contributor Author

Girgias commented Oct 8, 2023

Funny that you fixed this because of PHPStan, I reported it to them as: phpstan/phpstan#9970

@mblaney
Copy link
Member

mblaney commented Nov 2, 2023

thanks @Girgias

@mblaney mblaney merged commit 290e930 into simplepie:master Nov 2, 2023
8 of 9 checks passed
@Girgias Girgias deleted the remove-xml-set-object-call branch November 2, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Girgias @jtojnar @mblaney