ci: Add PHPStan #811
Merged
ci: Add PHPStan #811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Art4
reviewed
Mar 18, 2023
.github/workflows/ci.yml
Outdated
Comment on lines
49
to
50
| - name: Run static analysis | ||
| run: composer phpstan |
There was a problem hiding this comment.
What do you think about running PHPStan before running composer test?
There was a problem hiding this comment.
Since we use yoast/phpunit-polyfills, PHPUnit will not be available until tests are run.
jtojnar
force-pushed
the
phpstan
branch
6 times, most recently
from
8bfc333
to
7b1733b
Compare
jtojnar
commented
Mar 19, 2023
jtojnar
force-pushed
the
phpstan
branch
5 times, most recently
from
7455cc4
to
1277b4c
Compare
jtojnar
commented
Mar 20, 2023
src/IRI.php
Outdated
| * @property ?string $scheme | ||
| * @property ?string $userinfo | ||
| * @property ?string $host | ||
| * @property ?int $port |
There was a problem hiding this comment.
For level 3, we would need something like:
Suggested change
| * @property ?int $port | |
| * @property-read int|null $port | |
| * @property-write int|string|null $port |
But that is not currently supported phpstan/phpstan#9062
This should prevent whole swathes of bugs, especially once we increase the rule level.
Art4
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally, this would prevent issues like #802, #810, …
But this is just a beginning, targetting level 2 for now.
Depends on: