Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace idna_convert.class.php with Algo26\IdnaConvert, allow custom idna library #776

Closed
wants to merge 18 commits into from
Closed

Replace idna_convert.class.php with Algo26\IdnaConvert, allow custom idna library #776

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
6bf1f1f
Add tests for idna-convert library
Art4 Jan 24, 2023
afa1ff2
fix github actions
Art4 Jan 24, 2023
548afd2
Fix usage of idna-convert v2
Art4 Jan 24, 2023
4000a2c
Add IdnaDomainFilter and IdnaConverter
Art4 Jan 25, 2023
56bd323
Use IdnaDomainFilter instead of idna_convert in Enclosure class
Art4 Jan 25, 2023
26f226e
Move Idna support from Enclosure to Item class, remove RegistryAware …
Art4 Jan 25, 2023
adf023f
Add Registry test, move comment
Art4 Jan 25, 2023
dd50190
Remove idna_convert v0.5.1, delete idn folder
Art4 Jan 25, 2023
e7e83bc
Merge branch 'master' into allow-custom-idna-library
Art4 Jan 31, 2023
1ef6d7b
Remove `@package` and `@subpackage` tags
Art4 Jan 31, 2023
578bf64
Revert "Remove idna_convert v0.5.1, delete idn folder"
Art4 Jan 31, 2023
621051b
Rename method filter() to filterDomain()
Art4 Jan 31, 2023
5fe86e3
Add support for idna_convert 0.5.1 in IdnaConverter, add tests
Art4 Jan 31, 2023
26f66b3
Fix phpunit command, update actions/checkout action
Art4 Jan 31, 2023
3977fff
Fix tests with PHP 8.2 and idna-convert 0.5.1
Art4 Jan 31, 2023
a98c673
Test optional libraries with oldest and newest PHP version
Art4 Jan 31, 2023
c7c1aa3
improve test call, downgrade actions/checkout in favor of #783
Art4 Feb 1, 2023
cf407b5
Fix IdnaConverter to convert from IDN to Punycode
Art4 Feb 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Expand Up @@ -21,7 +21,7 @@ jobs:

steps:
- name: Checkout code
uses: actions/checkout@v2
uses: actions/checkout@v3

- name: Install PHP with latest composer
uses: shivammathur/setup-php@v2
Expand Down Expand Up @@ -62,7 +62,7 @@ jobs:

steps:
- name: Checkout code
uses: actions/checkout@v2
uses: actions/checkout@v3
Art4 marked this conversation as resolved.
Show resolved Hide resolved

- name: Install PHP with latest composer
uses: shivammathur/setup-php@v2
Expand All @@ -87,7 +87,7 @@ jobs:

- name: Run unit tests with idna_convert 0.5.1
if: ${{ matrix.with == 'idna-convert-v051' }}
run: composer test --bootstrap=tests/bootstrap-with-idna-convert-051.php
run: bin/phpunit --bootstrap=tests/bootstrap-with-idna-convert-051.php
Art4 marked this conversation as resolved.
Show resolved Hide resolved

- name: Run unit tests
if: ${{ matrix.with != 'idna-convert-v051' }}
Expand All @@ -98,7 +98,7 @@ jobs:

steps:
- name: Checkout code
uses: actions/checkout@v2
uses: actions/checkout@v3

- name: Install PHP
uses: shivammathur/setup-php@v2
Expand Down