This repository has been archived by the owner on Mar 7, 2021. It is now read-only.
Skip faulty URLs such as those missing a hostname or having an invali… #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like 30e38b9 somehow broke the integration test for node 8.x ? |
…d port number. Changes to be committed: modified: lib/crawler.js
|
Closing as this is currently discussed and pursued in medialize/URI.js#344 and medialize/URI.js#345. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #385
This needs fixing either in URI.js or in simplecrawler. I agree that it makes more sense to do it in URI.js, but I think it will take a lot more effort to refactor their validation code.
This prevents the crawler crashing on pages containing links such as