Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit status refactoring & differentiate originator of failign exit code #906

Merged
merged 9 commits into from
Aug 12, 2020

Commits on Aug 9, 2020

  1. Refactor result_exit_status

    This method was giant spaghetti, that was hard to maintain and
    fix stuff in.
    
    The new solution might seem overblown but with it's current
    interdependencies was the best I could come up with.
    
    Decided to decouple it a bit from asking SimpleCov itself for
    the coverage values to make it easier to test in isolation. No
    tests added as of right now though since it's tested quite a bit.
    
    The strategy to put each check into its own class produces more
    lines of code but makes their intent clearer and also makes it
    easier to figure out what belongs to what check.
    PragTob committed Aug 9, 2020
    Configuration menu
    Copy the full SHA
    385e8d9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7ddf117 View commit details
    Browse the repository at this point in the history
  3. Centralize the concept of what a rounded coverage looks like

    Don't have to pull the value through basically everything. Also,
    for us that's quite the important concept to have centralized.
    
    I'm not a fan of where it lives right now, but might come up
    with something new and better.
    PragTob committed Aug 9, 2020
    Configuration menu
    Copy the full SHA
    f5ce82a View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2020

  1. Inline set_exit_exception (only called once)

    Makes it easier to follow the code and there's no magic runnign
    there. Also makes our interface smaller.
    PragTob committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    9fe0ae8 View commit details
    Browse the repository at this point in the history
  2. Disentangle exit status handling & differntiate our vs. their err

    Refactoring this part made it clearer that all the different
    checks against success weren't necessary and could be done on
    a higher level removing lots and lots of branches on the lower
    level all checking for the same thing.
    
    Also implements the feature that we print different error
    messages for aborting on "we want to throw an error" vs.
    "we determined there was an error before".
    
    Decided to print out both in case we have a false positive then
    people can file better error reports of "you said there was
    an error before, but there wasn't!"
    
    Also deleted some tests as they dealt with cases that don't
    happen anymore/don't have to be checked anymore. Added some cukes
    to show that we say something else went wrong.
    
    Test suit holds up. Let's hope this won't be another billion
    fixes for minute details I forgot about and need to fix after
    the next release!
    PragTob committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    ed7a1b7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7d1c485 View commit details
    Browse the repository at this point in the history
  4. Add accidental fix for #891 to Changelog.

    When I accidentally fixed something, I hope I didn't accidentally
    break things.
    PragTob committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    b1ec967 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d69946e View commit details
    Browse the repository at this point in the history
  6. Feature test for not printing coverage violations!

    Currently waiting to hear about: grosser/parallel_tests#772
    PragTob committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    658be0c View commit details
    Browse the repository at this point in the history