bundle update rubocop capybara #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
bump_rubocop
branch
from
b7e313a
to
da1d93c
Compare
PragTob
reviewed
Jun 21, 2020
I wanted to upgrade `rubocop`, but there were conflicts with `capybara` dependencies so I had to upgrade `capybara` too. I order to prevent warnings about new cops not being enabled, I explicitly added all new cops as disabled.
deivid-rodriguez
force-pushed
the
bump_rubocop
branch
from
da1d93c
to
69504fa
Compare
PragTob
approved these changes
Jun 21, 2020
PragTob
added a commit
that referenced
this pull request
Jun 21, 2020
PragTob
added a commit
that referenced
this pull request
Jun 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to upgrade
rubocop, but there were conflicts withcapybaradependencies so I had to upgradecapybaratoo.I order to prevent warnings about new cops not being enabled, I introduced the
NewCops: disableconfiguration option.