Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only run our minitest plugin code if SimpleCov is indeed defined #878

Merged
merged 1 commit into from Feb 25, 2020

Conversation

PragTob
Copy link
Collaborator

@PragTob PragTob commented Feb 25, 2020

  • Fixes Problem with loading Minitest simplecov plugin #877
  • not quire sure whether we should wrap the entire thing in
    if undefined?(..) or not but since the file has all the right
    structure otherwise I'm more worried about minitest being
    weirded out that it doesn't find what it expects than I am
    of letting it execute an empty method
  • also yes the version workaround is maybe a bit weird, however
    I wanted our test suite to reproduce the exact failure case
    because otherwise it'd be to easy to just implement a
    respond_to? check which would have everything passing but would
    fail in real life.

* Fixes #877
* not quire sure whether we should wrap the entire thing in
if undefined?(..) or not but since the file has all the right
structure otherwise I'm more worried about minitest being
weirded out that it doesn't find what it expects than I am
of letting it execute an empty method
* also yes the version workaround is maybe a bit weird, however
I wanted our test suite to reproduce the exact failure case
because otherwise it'd be to easy to just implement a
respond_to? check which would have everything passing but would
fail in real life.
@PragTob PragTob merged commit 06225b5 into master Feb 25, 2020
@PragTob PragTob deleted the fix-minitest-plugin-without-simplecov branch February 25, 2020 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with loading Minitest simplecov plugin
1 participant