Convert utf8 #866
Merged
Convert utf8 #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruby won't execute "broken" files - but people can sure have them and force tracking them!
PragTob
added a commit
to simplecov-ruby/simplecov-html
that referenced
this pull request
Feb 22, 2020
This reverts commit 2608b9d. Replaced by: simplecov-ruby/simplecov#866 As suggested by: #91 (comment) Should be safe to revert as apparently ruby itself doesn't work when the encoding isn't declared properly so should be good. For files that aren't required by ruby but tracked we added a test case with broken encoding (in simplecov main) but it still seems to work. So this complexity is likely not needed anymore.
|
Well no release today due to me wanting to report jruby/jruby#6093 - see you back here tomorrow ;) |
Having it split up over to simplecov-html and part in "core" feels weird.
PragTob
added a commit
to simplecov-ruby/simplecov-html
that referenced
this pull request
Feb 23, 2020
This reverts commit 2608b9d. Replaced by: simplecov-ruby/simplecov#866 As suggested by: #91 (comment) Should be safe to revert as apparently ruby itself doesn't work when the encoding isn't declared properly so should be good. For files that aren't required by ruby but tracked we added a test case with broken encoding (in simplecov main) but it still seems to work. So this complexity is likely not needed anymore.
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Mar 8, 2020
Update ruby-simplecov to 0.18.5. 0.18.5 (2020-02-25) =================== Can you guess? Another bugfix release! ## Bugfixes * minitest won't crash if SimpleCov isn't loaded - aka don't execute SimpleCov code in the minitest plugin if SimpleCov isn't loaded. Thanks to [@edariedl](https://github.com/edariedl) for the report of the peculiar problem in [#877](simplecov-ruby/simplecov#877). 0.18.4 (2020-02-24) =================== Another small bugfix release 🙈 Fixes SimpleCov running with rspec-rails, which was broken due to our fixed minitest integration. ## Bugfixes * SimpleCov will run again correctly when used with rspec-rails. The excellent bug report [#873](simplecov-ruby/simplecov#873) by [@odlp](https://github.com/odlp) perfectly details what went wrong. Thanks to [@adam12](https://github.com/adam12) for the fix [#874](simplecov-ruby/simplecov#874). 0.18.3 (2020-02-23) =========== Small bugfix release. It's especially recommended to upgrade simplecov-html as well because of bugs in the 0.12.0 release. ## Bugfixes * Fix a regression related to file encodings as special characters were missing. Furthermore we now respect the magic `# encoding: ...` comment and read files in the right encoding. Thanks ([@Tietew](https://github.com/Tietew)) - see [#866](simplecov-ruby/simplecov#866) * Use `Minitest.after_run` hook to trigger post-run hooks if `Minitest` is present. See [#756](simplecov-ruby/simplecov#756) and [#855](simplecov-ruby/simplecov#855) thanks ([@adam12](https://github.com/adam12)) 0.18.2 (2020-02-12) =================== Small release just to allow you to use the new simplecov-html. ## Enhancements * Relax simplecov-html requirement so that you're able to use [0.12.0](https://github.com/colszowka/simplecov-html/blob/master/CHANGELOG.md#0120-2020-02-12)
jmgarnier
pushed a commit
to jmgarnier/reverse_coverage
that referenced
this pull request
Sep 27, 2021
incompatible character encodings: ASCII-8BIT and UTF-8 Taken from simplecov-ruby/simplecov#866
jmgarnier
pushed a commit
to jmgarnier/reverse_coverage
that referenced
this pull request
Sep 27, 2021
incompatible character encodings: ASCII-8BIT and UTF-8 Taken from simplecov-ruby/simplecov#866
DanielePalombo
added a commit
to nebulab/deprecations_detector
that referenced
this pull request
Jul 7, 2023
incompatible character encodings: ASCII-8BIT and UTF-8 Taken from simplecov-ruby/simplecov#866
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #865
I had a bit of trouble grasping the solution, so needed to play with myself and add some more tests to make sure nothing does/did explode.
Still probably want to add one acceptance test to make sure the html formatter doesn't blow it up for some reason.