Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crashes with uneven number of nocov instructions #847

Merged
merged 2 commits into from Jan 31, 2020
Merged

Conversation

PragTob
Copy link
Collaborator

@PragTob PragTob commented Jan 30, 2020

Fixes #846
We just assume them to go until the end. Test against a full nocov
for the file as well as a small mixture.

If this passes on CI I'll cut a new bugfix release.

cc: @DannyBen

@PragTob
Copy link
Collaborator Author

PragTob commented Jan 30, 2020

And it's failing on JRuby - yeehaawwww!

@PragTob
Copy link
Collaborator Author

PragTob commented Jan 30, 2020

And now github can't seem to reach the ubuntu packages or the IP is outdated and cached or what not so we can't get Java and run CI vs JRuby 😢

 Err:1 http://security.ubuntu.com/ubuntu bionic-updates/universe amd64 openjdk-8-jre-headless amd64 8u232-b09-0ubuntu1~18.04.1
  404  Not Found [IP: 52.168.50.79 80]
E: Failed to fetch http://security.ubuntu.com/ubuntu/pool/universe/o/openjdk-8/openjdk-8-jre-headless_8u232-b09-0ubuntu1~18.04.1_amd64.deb  404  Not Found [IP: 52.168.50.79 80]
E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?

@deivid-rodriguez
Copy link
Collaborator

I figure we could try running the workflow on https://github.com/docker-library/openjdk, so we don't need to install java everytime.

@PragTob
Copy link
Collaborator Author

PragTob commented Jan 30, 2020

yeah that seems like a great idea, right now I'm just "F5"ing hoping it comes back 😁

@PragTob
Copy link
Collaborator Author

PragTob commented Jan 30, 2020

Still borked :'(

@PragTob
Copy link
Collaborator Author

PragTob commented Jan 30, 2020

still broken, wow guess I really gotta go to docker land or something

Fixes #846
We just assume them to go until the end. Test against a full nocov
for the file as well as a small mixture.
Works on all the rubies, or let's see what our CI says :)
ref: jruby/jruby#6048
@PragTob
Copy link
Collaborator Author

PragTob commented Jan 31, 2020

Pulled in master without JDK installation. Should hopefully pass CI now and subsequently be released 💃

@PragTob PragTob merged commit 354bd9a into master Jan 31, 2020
@PragTob PragTob deleted the uneven-nocovs branch January 31, 2020 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: uneven number of nocov comments detected
2 participants