Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change misleading wording in exit message #739

Closed
wants to merge 1 commit into from
Closed

Change misleading wording in exit message #739

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions features/minimum_coverage.feature
View file
Open in desktop
Expand Up @@ -17,7 +17,7 @@ Feature:
When I run `bundle exec rake test`
Then the exit status should not be 0
And the output should contain "Coverage (88.10%) is below the expected minimum coverage (90.00%)."
And the output should contain "SimpleCov failed with exit 2"
And the output should contain "Exiting with status 2."

Scenario:
Given SimpleCov for Test/Unit is configured with:
Expand All @@ -32,7 +32,7 @@ Feature:
When I run `bundle exec rake test`
Then the exit status should not be 0
And the output should contain "Coverage (88.10%) is below the expected minimum coverage (88.11%)."
And the output should contain "SimpleCov failed with exit 2"
And the output should contain "Exiting with status 2."

Scenario:
Given SimpleCov for Test/Unit is configured with:
Expand Down
2 changes: 1 addition & 1 deletion lib/simplecov.rb
View file
Open in desktop
Expand Up @@ -186,7 +186,7 @@ def run_exit_tasks!
# Force exit with stored status (see github issue #5)
# unless it's nil or 0 (see github issue #281)
if exit_status && exit_status.positive?
$stderr.printf("SimpleCov failed with exit %d", exit_status)
$stderr.printf("Exiting with status %d.\n", exit_status)
Kernel.exit exit_status
end
end
Expand Down