Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore nil branches during parallel combine #1081

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shixianyangidme
Copy link

This issue had very similar cause of another pending PR: , but it is caused by parallel test. My project is based on ruby 3.1.4
If a parallel test (2 processes) generates two results on the same file:
Result A
"/Users/shixian.yang/workspace/test.rb": { "lines": [ 1, 1, null ] },
Result B
"/Users/shixian.yang/workspace/test.rb": { "lines": [ 0, 0, null ] },
Neither of results have "branches", the merge will generate a "branches": nil as a result. Finally it ends up in the error
NoMethodError: undefined method `flat_map' for nil:NilClass.

My plan is to ignore the "branches" field if neither A and B have "branches" exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant