Run Rubocop only once in CI (#1087)

No need to keep running rubocop, can esp. even be a bit slow on JRuby
simplecov-ruby · Apr 16, 2024 · 91f450e · 91f450e
1 parent 0c27173
commit 91f450e
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 8 deletions.
diff --git a/.github/workflows/stable.yml b/.github/workflows/stable.yml
@@ -29,13 +29,17 @@ jobs:
           ruby-version: ${{ matrix.ruby-version }}
           bundler-cache: true
 
+      - name: Run Rubocop
+        run: bundle exec rake rubocop
+        # code style is enough to check once (and might even take some time on JRuby)
+        if: matrix.ruby-version == '3.3'
+
       - name: Run tests
-        run: bundle exec rake
+        run: bundle exec rake test
         if: matrix.ruby-version != 'truffleruby'
 
-      # Run only `rake spec` on truffleruby, because just `rake` runs `rubocop spec cucumber`.
-      # There is no value to rerun rubocop here.
-      # cucumber fails because it uses an old childprocess which depends on fork.
+      # Run only `rake spec` on truffleruby, because just `rake` runs cucumber
+      # which fails because it uses an old childprocess which depends on fork.
       - name: Run specs (truffleruby)
         run: bundle exec rake spec
         if: matrix.ruby-version == 'truffleruby'
diff --git a/.github/workflows/unstable.yml b/.github/workflows/unstable.yml
@@ -28,12 +28,11 @@ jobs:
           bundler-cache: true
 
       - name: Run tests
-        run: bundle exec rake
+        run: bundle exec rake test
         if: matrix.ruby-version != 'truffleruby-head'
 
-      # Run only `rake spec` on truffleruby, because just `rake` runs `rubocop spec cucumber`.
-      # There is no value to rerun rubocop here.
-      # cucumber fails because it uses an old childprocess which depends on fork.
+      # Run only `rake spec` on truffleruby, because just `rake` runs cucumber
+      # which fails because it uses an old childprocess which depends on fork.
       - name: Run specs (truffleruby)
         run: bundle exec rake spec
         if: matrix.ruby-version == 'truffleruby-head'
diff --git a/Rakefile b/Rakefile
@@ -29,4 +29,5 @@ Cucumber::Rake::Task.new do |t|
   t.cucumber_opts = %w[--retry 3 --no-strict-flaky]
 end
 
+task test: %i[spec cucumber]
 task default: %i[rubocop spec cucumber]