Skip to content

Commit

Permalink
Explicitly print the exit status when SimpleCov fails the build (#688)
Browse files Browse the repository at this point in the history
* Explicitly print the exit status when SimpleCov fails the build

* I want those bonus points

* It might not be a build, so simplify the wording

* Update specs too, I am an idiot :)
  • Loading branch information
daemonsy authored and PragTob committed Jun 25, 2019
1 parent ba57b3c commit 7770ce8
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 1 deletion.
8 changes: 8 additions & 0 deletions CHANGELOG.md
@@ -1,3 +1,11 @@
<Version> <Date>
===================

## Enhancements

* Print the exit status explicitly when it's not a successful build so it's easier figure out SimpleCov failed the build in the output.


0.16.1 (2018-03-16)
===================

Expand Down
2 changes: 2 additions & 0 deletions features/minimum_coverage.feature
Expand Up @@ -17,6 +17,7 @@ Feature:
When I run `bundle exec rake test`
Then the exit status should not be 0
And the output should contain "Coverage (88.10%) is below the expected minimum coverage (90.00%)."
And the output should contain "SimpleCov failed with exit 2"

Scenario:
Given SimpleCov for Test/Unit is configured with:
Expand All @@ -31,6 +32,7 @@ Feature:
When I run `bundle exec rake test`
Then the exit status should not be 0
And the output should contain "Coverage (88.10%) is below the expected minimum coverage (88.11%)."
And the output should contain "SimpleCov failed with exit 2"

Scenario:
Given SimpleCov for Test/Unit is configured with:
Expand Down
5 changes: 4 additions & 1 deletion lib/simplecov.rb
Expand Up @@ -205,7 +205,10 @@ def run_exit_tasks!

# Force exit with stored status (see github issue #5)
# unless it's nil or 0 (see github issue #281)
Kernel.exit exit_status if exit_status && exit_status > 0
if exit_status && exit_status > 0
$stderr.printf("SimpleCov failed with exit %d", exit_status)
Kernel.exit exit_status
end
end

# @api private
Expand Down

0 comments on commit 7770ce8

Please sign in to comment.