Skip to content

Commit

Permalink
Resolve Ruby 2.5 inconsistency
Browse files Browse the repository at this point in the history
2.5 regarded the begin as "relevant" which we usually don't,
so I consider it a minor/not noteworthy 2.5 bug.

Ignoring the file in question, which we aren't interested in
the test coverage of should solve the problem.
  • Loading branch information
PragTob committed Feb 6, 2020
1 parent a6f5ee7 commit 66d74ee
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions features/minitest_basic.feature
Expand Up @@ -4,19 +4,20 @@ Feature:
Given SimpleCov for Minitest is configured with:
"""
require 'simplecov'
SimpleCov.start
SimpleCov.start do
add_filter "test_helper.rb"
end
"""

When I open the coverage report generated with `bundle exec rake minitest`
Then I should see the groups:
| name | coverage | files |
| All Files | 85.71% | 3 |
| All Files | 87.5% | 2 |

And I should see the source files:
| name | coverage |
| lib/faked_project/some_class.rb | 80.0 % |
| minitest/some_test.rb | 100.0 % |
| minitest/test_helper.rb | 75.0 % |

Scenario:
Given SimpleCov for Minitest is configured with:
Expand Down

0 comments on commit 66d74ee

Please sign in to comment.