Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update devDependencies to fix npm audit warnings #52

Merged
merged 2 commits into from Jan 15, 2022
Merged

Update devDependencies to fix npm audit warnings #52

merged 2 commits into from Jan 15, 2022

Conversation

ericcornelissen
Copy link
Collaborator

@ericcornelissen ericcornelissen commented Jan 5, 2022

Separating this out from runtime dependencies, see #51, so those can be merged and released as soon as possible.

As of 2022-01-08 there's still 4 audit warnings, all of which are for ansi-regex through commitizen > inquirer. This requires an update to commitizen which is currently pending in commitizen/cz-cli#874. 2022-01-15 update: The commitizen PR is still pending, I will merge this today.

Since the upgrade to Mocha in 310e197 has only fixed ansi-regex CVE's as well, and the CVE has limited impact in development environments, I'll be leaving this open for a bit to give commitizen a chance to update.

The npm audit report at b990a66 on 2022-01-08:
$ git switch update-dev-deps
Switched to branch 'update-dev-deps'

$ npm audit --development
                                                                                
                       === npm audit security report ===                        
                                                                                
┌──────────────────────────────────────────────────────────────────────────────┐
│                                Manual Review                                 │
│            Some vulnerabilities require your attention to resolve            │
│                                                                              │
│         Visit https://go.npm.me/audit-guide for additional guidance          │
└──────────────────────────────────────────────────────────────────────────────┘
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ Moderate      │  Inefficient Regular Expression Complexity in                │
│               │ chalk/ansi-regex                                             │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ ansi-regex                                                   │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in    │ >=5.0.1                                                      │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ commitizen [dev]                                             │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ commitizen > inquirer > string-width > strip-ansi >          │
│               │ ansi-regex                                                   │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://github.com/advisories/GHSA-93q8-gq69-wqmw            │
└───────────────┴──────────────────────────────────────────────────────────────┘
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ Moderate      │  Inefficient Regular Expression Complexity in                │
│               │ chalk/ansi-regex                                             │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ ansi-regex                                                   │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in    │ >=5.0.1                                                      │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ cz-conventional-changelog [dev]                              │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ cz-conventional-changelog > commitizen > inquirer >          │
│               │ string-width > strip-ansi > ansi-regex                       │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://github.com/advisories/GHSA-93q8-gq69-wqmw            │
└───────────────┴──────────────────────────────────────────────────────────────┘
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ Moderate      │  Inefficient Regular Expression Complexity in                │
│               │ chalk/ansi-regex                                             │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ ansi-regex                                                   │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in    │ >=5.0.1                                                      │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ commitizen [dev]                                             │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ commitizen > inquirer > strip-ansi > ansi-regex              │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://github.com/advisories/GHSA-93q8-gq69-wqmw            │
└───────────────┴──────────────────────────────────────────────────────────────┘
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ Moderate      │  Inefficient Regular Expression Complexity in                │
│               │ chalk/ansi-regex                                             │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ ansi-regex                                                   │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in    │ >=5.0.1                                                      │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ cz-conventional-changelog [dev]                              │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ cz-conventional-changelog > commitizen > inquirer >          │
│               │ strip-ansi > ansi-regex                                      │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://github.com/advisories/GHSA-93q8-gq69-wqmw            │
└───────────────┴──────────────────────────────────────────────────────────────┘
found 4 moderate severity vulnerabilities in 411 scanned packages
  4 vulnerabilities require manual review. See the full report for details.

Update mocha to the latest major version. Tests are still running so
everything _should_ be fine.
@ericcornelissen ericcornelissen added the dependencies Pull requests that update a dependency file label Jan 5, 2022
@ericcornelissen ericcornelissen marked this pull request as ready for review January 15, 2022 12:57
@ericcornelissen ericcornelissen merged commit 8aaef98 into simple-icons:master Jan 15, 2022
@ericcornelissen ericcornelissen deleted the update-dev-deps branch January 15, 2022 13:31
@github-actions
Copy link

🎉 This PR is included in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant