New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add XO linter #10643
Merged
Merged
Add XO linter #10643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mondeja
added
the
meta
Issues or pull requests regarding the project or repository itself
label
Mar 14, 2024
mondeja
reviewed
Mar 15, 2024
Really great, you're right about XO 🥇 |
mondeja
requested changes
Mar 19, 2024
mondeja
requested changes
Mar 19, 2024
mondeja
reviewed
Mar 19, 2024
mondeja
reviewed
Mar 19, 2024
mondeja
requested changes
Mar 19, 2024
mondeja
reviewed
Mar 19, 2024
mondeja
reviewed
Mar 19, 2024
mondeja
reviewed
Mar 19, 2024
uncenter
reviewed
Mar 19, 2024
uncenter
reviewed
Mar 19, 2024
LitoMore
force-pushed
the
xo
branch
2 times, most recently
from
March 20, 2024 10:18
7b7c0b4
to
f27a9dc
Compare
mondeja
requested changes
Mar 20, 2024
mondeja
requested changes
Mar 22, 2024
LitoMore
force-pushed
the
xo
branch
2 times, most recently
from
March 24, 2024 12:55
861c847
to
bd82a3b
Compare
mondeja
requested changes
Mar 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's almost there, just one more small change...
mondeja
approved these changes
Mar 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. Thanks for this great work @LitoMore! 🥇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I intentionally didn't fix those errors on the commit
64fefbd
(#10643), so you can play XO.Changes
eslint-ignore.
.svglintrc.mjs
code body toscripts/svglint-config.mjs
. It's related to XO not linting files starts with dot xojs/xo#673.prettier
dependency, XO has a built-in prettierprettier --fix
command to only format markdown and JSON filesengines
field frompackage.json
Features
It has a friendly error prompt, and you can simply the link on the prompt to see the reason:
It has tons of rules and good practices built in.
Let me know if you have any questions.
Editor configuration
VS Code
.vscode/settings.json
Some options can be omitted. It's up to your global configuration.
For other editors, please refer to https://github.com/xojs/xo?tab=readme-ov-file#editor-plugins.