Bump all packages to latest versions #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielemery
commented
Oct 21, 2023
| "eslint-config-prettier": "^8.5.0", | ||
| "eslint-plugin-prettier": "^4.0.0", | ||
| "prettier": "^2.6.1" | ||
| "@trivago/prettier-plugin-sort-imports": "^4.2.0", |
There was a problem hiding this comment.
@simonpratt what are these dev dependencies actually used for? Are they needed?
There was a problem hiding this comment.
I not really sure. From memory the packages required to use prettier with eslint have change quite a bit since I last touched this package.json
There was a problem hiding this comment.
I think most of the packages are probably needed by the consumer. Which your nice cli utility installs on their behalf 😄
I'm just wondering what the dev dependencies are for, maybe they're here with a view to implementing some tests of the linting setup in this repo in the future?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated package versions to latest.
There is still a "critical" vulnerability outstanding that appears to be about to be fixed: trivago/prettier-plugin-sort-imports#263
So I might wait for it to be merged & deployed before we merge this.
Fixes #2