Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release-it and release-it-lerna-changelog. #6

Merged
merged 1 commit into from Oct 22, 2020

Conversation

rwjblue
Copy link
Contributor

@rwjblue rwjblue commented Oct 20, 2020

Essentially reverts edb82f7 and updates to a version of release-it-lerna-changelog that does not have a direct dependency on release-it.

The root cause of the issue is explained over in release-it/release-it#713, but the tldr is that I had a bit of work to refactor my plugins to avoid the direct dependency on release-it.

Essentially reverts edb82f7 and updates
to a version of `release-it-lerna-changelog` that does not have a direct
dependency on `release-it`.
@simonihmig
Copy link
Owner

Oh wow, thanks a lot! 😍

The root cause of the issue is explained over in release-it/release-it#713, but the tldr is that I had a bit of work to refactor my plugins to avoid the direct dependency on release-it.

Yeah, I just noticed this issue in a different project, before seeing this PR. So thanks again, what a service! :) (I wonder how you even noticed this was used here!?)

@simonihmig simonihmig merged commit 576fa0a into simonihmig:master Oct 22, 2020
@rwjblue rwjblue deleted the fix-release-it-setup branch October 22, 2020 20:47
@rwjblue
Copy link
Contributor Author

rwjblue commented Oct 22, 2020

I wonder how you even noticed this was used here!?

Your commit message was the first hit when I was also searching for a solution to the error:

https://github.com/search?q=%22plugin.getIncrement+is+not+a+function%22&type=commits

Figured that I'd share the knowledge once I figured out what was going on...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants