Update default API version to v19.0 #389
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @wynksaiddestroy, would you mind to add Bigdecimal to gemfile to fix head build as well? |
Thanks for the quick response ❤️ |
|
Just a friendly heads-up: Thanks for cutting a release soonish, the v13 API won't work after May 28, so it would be nice to have a few days to update. And thanks for this PR, @wynksaiddestroy ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
omniauth-facebook still uses Graph API version 5.0 as the default, which was shut off in February 2022.
The current API version is v19.0. A quick google search didn't yield any changes to the OAuth part of the API. So I assume it's safe to use the current version of the API.
#374 addressed the problem already.
On the side I updated the CI test matrix and removed all unmaintained Ruby versions.