aes: initial implementation of most aes instructions #1072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed trailing whitespaces commented unused variables changed const variable to define
mr-c
requested changes
Oct 12, 2023
|
Please also rebase upon https://github.com/simd-everywhere/simde/tree/master to get the latest changes. Having no file conflicts is necessary for the CI to run. |
|
I see that the neon implementations (with and without crypto extensions) at DLTcollab/sse2neon#6 are also MIT licensed See also |
mr-c
reviewed
Oct 12, 2023
removed semicolon from define
|
Whoops, I should have said |
mr-c
reviewed
Oct 12, 2023
changed two casts
mr-c
reviewed
Oct 12, 2023
Co-authored-by: Michael R. Crusoe <1330696+mr-c@users.noreply.github.com>
mr-c
reviewed
Oct 12, 2023
|
Michael, Thanks for review! I am not going to add optimizations for other platforms. It is very interesting, but I don't currently have free time for it :) |
mr-c
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Regarding issue #45
I've adapted AES encryption/decryption instructions using algorithm from this project https://github.com/dhuertas/AES
The code is straight forward with a very basic optimization using a lookup table for the most time consuming function.
The only modification I did to the original implementation is throwing away 90% of unused lookup table data, leaving only 2 KB of the initial 60 KB.