Remove type: module
from published app/lib package.json
#931
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying this fix for #914. I've tested @h5web/app with CRA v5 outside of the repo and came across a couple of errors that I managed to fix by removing
"type": "module"
from the package, so I thought I'd give it a try.Note that
"type": "module"
is required in development, so I "revert" it by setting to"commonjs"
inside"publishConfig"
.I'll publish a beta version once merged.