Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Set extension hook implementation visibility to protected #11252

Merged

Conversation

emteknetnz
Copy link
Member

Issue #10514

First PR didn't include test dirs

@emteknetnz emteknetnz force-pushed the pulls/6/protect-hooks2 branch 2 times, most recently from e32d462 to f6941e0 Compare May 20, 2024 04:58
tests/php/Security/MemberTest.php Outdated Show resolved Hide resolved
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit 1217806 into silverstripe:6 May 20, 2024
15 checks passed
@GuySartorelli GuySartorelli deleted the pulls/6/protect-hooks2 branch May 20, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants