MNT Remove scrutinizer config. #10396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that I don't have the necessary permissions to tell scrutinizer to actually stop running on PRs - someone in @silverstripe/core-team will need to tackle that part. |
emteknetnz
approved these changes
Jul 8, 2022
|
I'm assuming that just removing the config is enough? There's not setting in github to 'turn off' scrutinezer as far as I'm aware |
|
Ah right, it's in as a webhook on a per repo basis. I'll remove the one in framework. I have no idea what repos it's enabled on, so if you see any others let me know |
|
Yeah I haven't had a look around - I'll create PRs removing config (and tag you to remove webhooks) when and as I notice scrutinized on PRs. Doesn't seem too wide spread. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scrutinizer builds are failing because they don't have
allowed_pluginsconfig set in composer.We've discussed this internally and decided that we're not using this anyway, so the easiest solution is just to remove it.