Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Use DataColumns content when available in CSV export #10310

Conversation

sig-steve
Copy link
Contributor

Fix #9248 broke #9173 by accidentally checking for a string key in a
numerically indexed array. Change the check to search the array instead
(fixes #10308)

@GuySartorelli
Copy link
Member

Thanks Steve! Can you please retarget this to the 4.10 branch? That way we can include this in a patch release and it can be used without waiting for the next minor.

@sig-steve sig-steve changed the base branch from 4 to 4.10 May 12, 2022 21:44
@sig-steve sig-steve force-pushed the fix/10308--datacolumns-in-csv-export branch from 5121a9c to b05db52 Compare May 12, 2022 21:54
@GuySartorelli
Copy link
Member

GuySartorelli commented May 12, 2022

The travis build erroring is due to the way the travis-shared-config is configured. There's a hardcoded workaround to make sure the current minor branch gets the correct dependencies - this is hardcoded because we're intending to move to github actions and the effort of making it dynamic with travis config was deemed not worth it, but it does cause problems such as this one when we're in beta.

I'll run the tests locally.

@sig-steve
Copy link
Contributor Author

Done. Looks like Travis CI cannot pass as the test suite appears to be requiring silverstripe/framework ^4.11, which won't work for this patch on 4.10.

@GuySartorelli
Copy link
Member

I've created a PR to resolve the travis mismatch in #10315 - once that is merged I'll ask you to rebase so we can see the tests go green.

@GuySartorelli
Copy link
Member

@sig-steve The fix for the travis builds has been merged into 4.10 - can you please pull and rebase? That should allow the tests to pass.

Fix silverstripe#9248 broke silverstripe#9173 by accidentally checking for a string key in a
numerically indexed array. Change the check to search the array instead
(fixes silverstripe#10308)
@sig-steve sig-steve force-pushed the fix/10308--datacolumns-in-csv-export branch from 756b354 to e91b7be Compare May 13, 2022 01:53
@GuySartorelli GuySartorelli merged commit 67d5c15 into silverstripe:4.10 May 13, 2022
@GuySartorelli
Copy link
Member

@sig-steve Tagged as 4.10.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSV Export not populating generated columns
2 participants