FIX Default GridField search fields with an index of 0 to use StartWithFilter #10211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
force-pushed
the
pulls/4.10/seach-filter-tests
branch
from
f3a0b44
to
2b9633f
Compare
2 tasks
maxime-rainville
requested changes
Mar 16, 2022
| @@ -347,7 +348,7 @@ public function scaffoldSearchFields($dataClass) | |||
| // so we need to check the original setting. | |||
| // If the field is defined $searchable_fields = array('MyField'), | |||
| // then default to StartsWith filter, which makes more sense in this context. | |||
| if (!$customSearchableFields || array_search($name, $customSearchableFields)) { | |||
| if (!$customSearchableFields || array_search($name, $customSearchableFields) !== false) { | |||
There was a problem hiding this comment.
I'm a little confused why we think StartsWith makes more sense in this context then PartialMatch.
But otherwise, the fix address a legitimate mismatch between the intention of the class and the actual behaviour.
michalkleiner
approved these changes
Mar 16, 2022
emteknetnz
force-pushed
the
pulls/4.10/seach-filter-tests
branch
from
2b9633f
to
740d087
Compare
maxime-rainville
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
array_search will return 0 if it matched the first value in an array
Also add a unit test for #9991