Merge pull request #11245 from creative-commoners/pulls/6/protect-hooks

API Set extension hook implementation visibility to protected

src/Forms/CompositeValidator.php

@@ -26,7 +26,7 @@
  *
  * Or by implementing the updateCMSCompositeValidator() method in a DataExtension:
  *
- * public function updateCMSCompositeValidator(CompositeValidator $compositeValidator): void
+ * protected function updateCMSCompositeValidator(CompositeValidator $compositeValidator): void
  * {
  *   $compositeValidator->addValidator(RequiredFields::create(['AdditionalContent']));
  * }

src/ORM/DataExtension.php

@@ -35,7 +35,7 @@ public function validate(ValidationResult $validationResult)
      * @param SQLSelect $query Query to augment.
      * @param DataQuery $dataQuery Container DataQuery for this SQLSelect
      */
-    public function augmentSQL(SQLSelect $query, DataQuery $dataQuery = null)
+    protected function augmentSQL(SQLSelect $query, DataQuery $dataQuery = null)
     {
     }
 
@@ -45,7 +45,7 @@ public function augmentSQL(SQLSelect $query, DataQuery $dataQuery = null)
      * When duplicating a table's structure, remember to duplicate the create options
      * as well. See {@link Versioned->augmentDatabase} for an example.
      */
-    public function augmentDatabase()
+    protected function augmentDatabase()
     {
     }
 
@@ -54,7 +54,7 @@ public function augmentDatabase()
      *
      * @param array $manipulation Array of operations to augment.
      */
-    public function augmentWrite(&$manipulation)
+    protected function augmentWrite(&$manipulation)
     {
     }
 
@@ -206,7 +206,7 @@ public function extraStatics($class = null, $extension = null)
      *
      * @param FieldList $fields FieldList with a contained TabSet
      */
-    public function updateCMSFields(FieldList $fields)
+    protected function updateCMSFields(FieldList $fields)
     {
     }
 
@@ -217,7 +217,7 @@ public function updateCMSFields(FieldList $fields)
      *
      * @param CompositeValidator $compositeValidator
      */
-    public function updateCMSCompositeValidator(CompositeValidator $compositeValidator): void
+    protected function updateCMSCompositeValidator(CompositeValidator $compositeValidator): void
     {
     }
 
@@ -229,7 +229,7 @@ public function updateCMSCompositeValidator(CompositeValidator $compositeValidat
      *
      * @param FieldList $fields FieldList without TabSet nesting
      */
-    public function updateFrontEndFields(FieldList $fields)
+    protected function updateFrontEndFields(FieldList $fields)
     {
     }
 
@@ -239,7 +239,7 @@ public function updateFrontEndFields(FieldList $fields)
      *
      * @param FieldList $actions FieldList
      */
-    public function updateCMSActions(FieldList $actions)
+    protected function updateCMSActions(FieldList $actions)
     {
     }
 
@@ -251,7 +251,7 @@ public function updateCMSActions(FieldList $actions)
      *
      * @param array $fields Array of field names
      */
-    public function updateSummaryFields(&$fields)
+    protected function updateSummaryFields(&$fields)
     {
         $summary_fields = Config::inst()->get(static::class, 'summary_fields');
         if ($summary_fields) {
@@ -274,7 +274,7 @@ public function updateSummaryFields(&$fields)
      *
      * @param array $labels Array of field labels
      */
-    public function updateFieldLabels(&$labels)
+    protected function updateFieldLabels(&$labels)
     {
         $field_labels = Config::inst()->get(static::class, 'field_labels');
         if ($field_labels) {

src/ORM/DataObject.php

@@ -4476,7 +4476,7 @@ protected function mergeRelatedObject($list, $added, $item)
      * The framework extend method will return combined values from DataExtension method(s) as an array
      * The method on your DataExtension class should return a single scalar value. For example:
      *
-     * public function cacheKeyComponent()
+     * protected function cacheKeyComponent()
      * {
      *      return (string) $this->owner->MyColumn;
      * }