Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH Various fixes for PHP 8.1 compatibility #485

Merged
merged 1 commit into from Apr 13, 2022
Merged

ENH Various fixes for PHP 8.1 compatibility #485

merged 1 commit into from Apr 13, 2022

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz mentioned this pull request Apr 7, 2022
Closed
@emteknetnz emteknetnz marked this pull request as ready for review April 13, 2022 03:33
GuySartorelli
GuySartorelli approved these changes Apr 13, 2022
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I'm surprised it returns 'text/plain' in <8.1

@GuySartorelli GuySartorelli merged commit bd71554 into silverstripe:1 Apr 13, 2022
@GuySartorelli GuySartorelli deleted the pulls/1/p81fix branch April 13, 2022 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@emteknetnz @GuySartorelli