API Create extension hook for updating session grant on files #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
force-pushed
the
pulls/1/shortcode-grant
branch
from
ab46d54
to
4745454
Compare
4 tasks
emteknetnz
force-pushed
the
pulls/1/shortcode-grant
branch
from
4745454
to
ddcd3b1
Compare
andrewandante
approved these changes
Oct 12, 2021
|
Looking reasonable from my perspective as well, just one minor ask if we could add an inline comment explaining why we explicitly pass |
emteknetnz
commented
Oct 13, 2021
emteknetnz
force-pushed
the
pulls/1/shortcode-grant
branch
from
ddcd3b1
to
aa30f44
Compare
emteknetnz
force-pushed
the
pulls/1/shortcode-grant
branch
from
aa30f44
to
45a8887
Compare
michalkleiner
approved these changes
Oct 13, 2021
emteknetnz
force-pushed
the
pulls/1/shortcode-grant
branch
from
45a8887
to
640f8da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/silverstripe-sharedraftcontent#132