-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
There was no strong reason for maintaining project references, especially because some of the tooling doesn't support it. By using a single config we make TypeScript checks faster and tools aren't running into problems. - TypeScript ESLint: typescript-eslint/typescript-eslint#2094 - eslint-import-resolver-typescript: typescript-eslint/typescript-eslint#2094 - Vitest: vitest-dev/vitest#3752 - Remix also didn't work, but I wasn't able to find the issue, probablt esbuild So that's at least 4 tools not working. 😄
- Loading branch information
Showing
7 changed files
with
19 additions
and
55 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,6 +10,3 @@ node_modules | |
/test-results/ | ||
/playwright-report/ | ||
/playwright/.cache/ | ||
|
||
# TypeScript | ||
*.tsbuildinfo |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,4 +21,4 @@ pre-push: | |
playwright: | ||
run: npx playwright test | ||
typescript: | ||
run: npx tsc --build | ||
run: npx tsc --noEmit |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1,23 @@ | ||
{ | ||
"files": [], | ||
"references": [ | ||
{ "path": "./tsconfig.app.json" }, | ||
{ "path": "./tsconfig.e2e.json" }, | ||
], | ||
"compilerOptions": { | ||
// ESLint, Vitest & Remix don't seem to support Project References yet, | ||
// duplicating this mapping here helps them resolve the module paths | ||
// https://github.com/import-js/eslint-import-resolver-typescript/issues/94 | ||
// https://github.com/vitest-dev/vitest/issues/3752 | ||
"lib": ["DOM", "DOM.Iterable", "ES2020"], | ||
"types": ["vitest/globals"], | ||
"isolatedModules": true, | ||
"esModuleInterop": true, | ||
"jsx": "react-jsx", | ||
"module": "CommonJS", | ||
"moduleResolution": "node", | ||
"resolveJsonModule": true, | ||
"target": "ES2020", | ||
"strict": true, | ||
"allowJs": true, | ||
"forceConsistentCasingInFileNames": true, | ||
"paths": { | ||
"~/*": ["./app/*"], | ||
}, | ||
"skipLibCheck": true, | ||
|
||
// Remix takes care of building everything in `remix build`. | ||
"noEmit": true, | ||
}, | ||
} |