Upgrade Python dependencies & use mypy strict mode #1238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
johnthagen
changed the title
jmgrady
approved these changes
Jul 2, 2021
There was a problem hiding this comment.
Reviewed 3 of 4 files at r1, 8 of 8 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @johnthagen)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade Python dependencies.
mypy0.9xx which allows us to move its configuration intopyproject.tomlso all Python tools are configured in a single location. This allows us to delete thesetup.cfgfile.mypystrict mode, to increase type checking within Python codeisortto version 5.8.0 for now to avoid this issue: skips are not honored since isort 5.9.x PyCQA/isort#1762This change is