Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 5.3.4 - Fix ProfileWizard stepper after use of browser's Back button #150

Merged
merged 2 commits into from
Mar 28, 2024
Merged

Release 5.3.4 - Fix ProfileWizard stepper after use of browser's Back button #150

merged 2 commits into from
Mar 28, 2024

Conversation

forevermatt
Copy link
Contributor

Fixed

  • Reset the list of relevant steps each time so it is properly initialized.
    • Without this, using the browser's Back button leaves the old list of steps, which may or may not match the current URL path when the user clicks a tile from their profile dashboard.
    • Unfortunately, with this the list of steps (most noticeably during initial onboarding) doesn't keep the completed steps in the progress bar at the top. A separate issue is being added to our backlog about that bug.

forevermatt and others added 2 commits March 28, 2024 14:28
@forevermatt
Reset the list of relevant steps each time so it is properly initialized
5e16cb8 
Without this, going to a step, hitting the browser's Back button, then
going to another step (e.g. change password, back, change password
recovery) gave this error:
`Cannot read properties of undefined (reading 'id') on Profile UI`

It seemed to be because currentStep was undefined because the current
URL path didn't match any of the "relevant" steps (since they hadn't
been updated).
@forevermatt
Merge pull request #149 from silinternational/feature/reset-wizard-st…
daeb593 
…eps-each-time

Reset the list of relevant steps each time so it is properly initialized
@forevermatt forevermatt requested a review from a team March 28, 2024 19:07
@briskt
Copy link
Contributor

briskt commented Mar 28, 2024

Addresses issue IDP-947. New issue IDP-952

@forevermatt forevermatt merged commit 5c1b5b0 into main Mar 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briskt briskt briskt approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@forevermatt @briskt