feat: introduce esm and cjs support #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n1ru4l
changed the title
|
LGTM |
sikanhe
approved these changes
Feb 22, 2021
|
Please not merge yet I still need to confirm out whether it works correctly with the most common use-cases |
|
@n1ru4l feel free to merge when you have it working! |
n1ru4l
force-pushed
the
feat-esm-cjs
branch
3 times, most recently
from
3f7134f
to
dbe8740
Compare
|
Ok, it seems to work. It is a bit ugly though and all the files had to be moved to the package root... But it seems like its the only way to properly support both ESM and typescript in a backwards-compatible way until typescript introduces proper ESM support... See https://unpkg.com/browse/gqtx@0.8.1-913ef0b2.0/ for a file directory overview. Gonna leave this open for a few days if anyone has some more feedback. Otherwise, I will merge it probably some day on the weekend. Maybe @zth has something to add? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am following this comment:
d3/d3#3469 (comment)
This should close #3 (and also #42)
See https://unpkg.com/browse/gqtx@0.8.1-a9325d31.0/ for a folder structure overview of the published package.See https://unpkg.com/browse/gqtx@0.8.1-913ef0b2.0/ for a file directory overview.