feat: collect bootstrap timing metrics #275
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
reviewed
Jun 21, 2019
| let perf_hooks; | ||
|
|
||
| try { | ||
| // eslint-disable-next-line |
There was a problem hiding this comment.
can you disable the specific rule?
There was a problem hiding this comment.
I'm sorry, but its looks like I can not disable only specific rule.
For node 6.x I should use
//eslint-disable-next-line node/no-missing-require
But for newer versions of node I should use
//eslint-disable-next-line node/no-unsupported-features/node-builtins
But I can not specify both rules. So I rolled back this to just
//eslint-disable-next-line
SimenB
requested changes
Jun 21, 2019
lib/metrics/bootstrapTime.js
Outdated
| const now = Date.now(); | ||
|
|
||
| if (entry.nodeStart !== -1) { | ||
| nodeStart.set({}, entry.nodeStart, now); |
There was a problem hiding this comment.
we have an option for disabling timestamps - mind adding code handling it?
yvasiyarov
force-pushed
the
bootstrap
branch
from
ef1135f
to
46daca9
Compare
zbjornson
force-pushed
the
master
branch
2 times, most recently
from
d6f2cf6
to
29b6d86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collect bootstrap timing metrics