Fix: support certificate pem type #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kenny Leung <kleung@chainguard.dev>
|
Would be good to add a test case |
Signed-off-by: Kenny Leung <kleung@chainguard.dev>
added test |
dekkagaijin
approved these changes
Aug 21, 2022
|
Thanks for making a fix! However, can we revert this? This will cause issues if you try to pass a PEM-encoded certificate, the PKIX parsing will fail. When calling The Fulcio test is what's wrong, it should be creating a PEM-encoded public key with |
|
Ah, I see why the Fulcio tests broke. A PR added PEM block type checking to return a better error message. Previously, the PEM block type didn't matter, so even though the Fulcio test was constructing invalid test input, the tests still passed. So yea, the correct fix is just to fix the Fulcio test, and revert this. |
k4leung4
added a commit
to k4leung4/sigstore
that referenced
this pull request
Aug 21, 2022
This reverts commit 44be03d.
k4leung4
added a commit
to k4leung4/sigstore
that referenced
this pull request
Aug 21, 2022
This reverts commit 44be03d. Signed-off-by: Kenny Leung <kleung@chainguard.dev>
dlorenc
pushed a commit
that referenced
this pull request
Aug 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kenny Leung kleung@chainguard.dev
Summary
Change is needed to get fulcio test to pass. See https://github.com/sigstore/fulcio/runs/7935433305?check_suite_focus=true
My understanding is that CertificatePEMType is also valid. If not, tests in fulcio will need to be fixed.
https://github.com/sigstore/fulcio/blob/main/pkg/server/grpc_server_test.go#L383
Release Note
Documentation