feat: allow to create static instances of some objects #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow to create `static` instances of the `cosign::Client`, `sigstore::trust::ManualTrustRoot`. The ability to create `static` instances of these objects can simplify the downstream consumers of this library. The approach taken to create these `static` instance is the same used by [`rustls_pki_types::CertificateDer::into_owned`](https://docs.rs/rustls-pki-types/1.4.1/rustls_pki_types/struct.CertificateDer.html#method.into_owned) Signed-off-by: Flavio Castelli <fcastelli@suse.com>
This was referenced Apr 10, 2024
viccuad
approved these changes
Apr 12, 2024
|
Putting on hold, because of #311. This is probably going to be closed |
|
Closing, this is no longer needed with the latest changes that landed into the |
flavio
deleted the
allow-to-create-static-copies-of-structs-with-a-lifetime
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to create
staticinstances of thecosign::Client,sigstore::trust::ManualTrustRoot.The ability to create
staticinstances of these objects can simplify the downstream consumers of this library.The approach taken to create these
staticinstance is the same used byrustls_pki_types::CertificateDer::into_owned