Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak linting target #171

Merged
merged 2 commits into from Jul 21, 2022
Merged

Tweak linting target #171

merged 2 commits into from Jul 21, 2022

Conversation

woodruffw
Copy link
Member

This follows the same pattern as Warehouse, and splits make lint into two separate targets:

  • make lint: Run all linters, exiting with nonzero if any fail
  • make reformat: Run the subset of linters that can automatically rewrite the source

Closes #169.

Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw woodruffw added the qa quality assurance label Jul 21, 2022
@woodruffw woodruffw requested review from di and tetsuo-cpp July 21, 2022 14:24
@woodruffw woodruffw self-assigned this Jul 21, 2022
@woodruffw woodruffw enabled auto-merge (squash) July 21, 2022 14:24
Copy link
Collaborator

@tetsuo-cpp tetsuo-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@woodruffw woodruffw merged commit a035704 into main Jul 21, 2022
@woodruffw woodruffw deleted the ww/more-lint-fixing branch July 21, 2022 14:27
@woodruffw
Copy link
Member Author

Ah, maybe I should stop enabling auto-merge, since @di probably wanted to also give feedback on this 😅

Copy link
Member

@di di left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa quality assurance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants