Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delegation documentation #728

Merged
merged 14 commits into from
Mar 24, 2023

Conversation

kommendorkapten
Copy link
Member

Summary

Closes #703
Adds documentation on how to add a delegation during a signing ceremony.

Rendered version

Release Note

N/A

Documentation

This PR is the updated documentation

asraa
asraa previously approved these changes Mar 16, 2023
playbooks/ORCHESTRATION.md Outdated Show resolved Hide resolved
playbooks/ORCHESTRATION.md Outdated Show resolved Hide resolved
playbooks/ORCHESTRATION.md Outdated Show resolved Hide resolved
playbooks/ORCHESTRATION.md Outdated Show resolved Hide resolved
playbooks/ORCHESTRATION.md Show resolved Hide resolved
Copy link
Member

@joshuagl joshuagl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't been paying enough attention here of late and this looks so cool, I hope this review is useful!

playbooks/ORCHESTRATION.md Outdated Show resolved Hide resolved
playbooks/ORCHESTRATION.md Outdated Show resolved Hide resolved
playbooks/ORCHESTRATION.md Outdated Show resolved Hide resolved
playbooks/ORCHESTRATION.md Outdated Show resolved Hide resolved
Comment on lines +139 to +144
After the delegation metadata is added and signed, the delegation
keyholder should open a PR against the ceremony branch.
The name of the PR MUST be `feat/add-delegation for
<delegation-name>`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we provide a snippet here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For an example PR, i.e the updated targets.json and an example role metadata file?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of the PR generation in this repo is automated, I'm wondering if we can do the same here? Maybe an enhancement in a future PR?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I have tooling for this, that manages all the work but currently it's not OSS. I would like to make so pretty soon.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll file a follow-up issue with references to these comments.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


As part of running the `add-delegaton` command, a POP (proof of
possession) has to be generated too. The computed POP should be stored
in `${REPO}/staged/${FORK_POINT}.sig`, where the fork point is the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when you say "should be stored in" does that mean the person following these instructions has to do something? if this is done automatically by one of the commands below, we might say "will be stored in ..."

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently there is no automation done for this, but it's shown in the stanza below:

$ FORK_POINT=$(git merge-base --fork-point origin/main "${BRANCH}") \
      ./tuf key-pop-sign \
      -key ${KEY_REF} \
      -challenge ${DELEGATION_NAME} \
      -nonce ${FORK_POINT} > ${REPO}/staged/${FORK_POINT}.sig

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or there is, but none that's open source. Yet.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently there is no automation done for this, but it's shown in the stanza below:

This is probably sufficient for now, thanks.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example in the documentation should show all steps required to create a delegation, and then the delegate owner could open a PR with the change-set to have it merged. So there should be no uncertainties, if so let me know and I will update the doc 😄

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kommendorkapten and others added 11 commits March 17, 2023 15:08
Signed-off-by: Fredrik Skogman <kommendorkapten@github.com>
Signed-off-by: Fredrik Skogman <kommendorkapten@github.com>
Signed-off-by: Fredrik Skogman <kommendorkapten@github.com>
Co-authored-by: asraa <asraa@google.com>
Signed-off-by: Fredrik Skogman <kommendorkapten@github.com>
Co-authored-by: asraa <asraa@google.com>
Signed-off-by: Fredrik Skogman <kommendorkapten@github.com>
Co-authored-by: asraa <asraa@google.com>
Signed-off-by: Fredrik Skogman <kommendorkapten@github.com>
Signed-off-by: Fredrik Skogman <kommendorkapten@github.com>
Co-authored-by: Joshua Lock <joshuagloe@gmail.com>
Signed-off-by: Fredrik Skogman <kommendorkapten@github.com>
Co-authored-by: Joshua Lock <joshuagloe@gmail.com>
Signed-off-by: Fredrik Skogman <kommendorkapten@github.com>
Co-authored-by: Joshua Lock <joshuagloe@gmail.com>
Signed-off-by: Fredrik Skogman <kommendorkapten@github.com>
Signed-off-by: Fredrik Skogman <kommendorkapten@github.com>
Signed-off-by: Fredrik Skogman <kommendorkapten@github.com>
asraa
asraa previously approved these changes Mar 21, 2023
playbooks/ORCHESTRATION.md Outdated Show resolved Hide resolved
Co-authored-by: asraa <asraa@google.com>
Signed-off-by: Fredrik Skogman <kommendorkapten@github.com>
asraa
asraa previously approved these changes Mar 23, 2023
playbooks/ORCHESTRATION.md Outdated Show resolved Hide resolved
Comment on lines +139 to +144
After the delegation metadata is added and signed, the delegation
keyholder should open a PR against the ceremony branch.
The name of the PR MUST be `feat/add-delegation for
<delegation-name>`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


As part of running the `add-delegaton` command, a POP (proof of
possession) has to be generated too. The computed POP should be stored
in `${REPO}/staged/${FORK_POINT}.sig`, where the fork point is the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Co-authored-by: asraa <asraa@google.com>
Signed-off-by: Fredrik Skogman <kommendorkapten@github.com>
@kommendorkapten kommendorkapten merged commit 38967a5 into sigstore:main Mar 24, 2023
@kommendorkapten kommendorkapten deleted the delegation_documentaton branch September 13, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v7] [docs] Update ORCHESTRATION.md documents with a delegation step
4 participants