Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump: update go-tuf and add testing for hex encoded sign verify #374

Merged
merged 2 commits into from
Sep 12, 2022

Conversation

asraa
Copy link
Contributor

@asraa asraa commented Sep 12, 2022

Signed-off-by: Asra Ali asraa@google.com

This is PART 1 of the plan to implement hex to PEM ecdsa key migration:
#329 (comment)

Summary

  • deps: bumps go-tuf
  • Adds a granular testing that a signature using the SignCmd can verify against the go-tuf verifier.

This does not change any functionality in the code. We are still using ECDSA keys for the HSM and online key signers. Wait for the following parts of the change!

Release Note

Documentation

Signed-off-by: Asra Ali <asraa@google.com>
@asraa asraa marked this pull request as ready for review September 12, 2022 15:28
@kommendorkapten
Copy link
Member

Nice to see that a lot of code was removed and replaced with the keys.EcdsaTufKey function!

@asraa
Copy link
Contributor Author

asraa commented Sep 12, 2022

Nice to see that a lot of code was removed and replaced with the keys.EcdsaTufKey function!

Preparation for deprecating it hehe 👿

Signed-off-by: Asra Ali <asraa@google.com>
Copy link
Member

@kommendorkapten kommendorkapten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@asraa asraa merged commit 93d5619 into sigstore:main Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants