compute payload and envelope hashes upon validating intoto proposed entries #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the digest of the envelope contents was computed before returning the canonicalized byte stream that is inserted into the log, but was not stored in the internal object representation so it was not available when IndexKeys was called. This fixes it to be available, and also has the benefit of ignoring the client provided value (as we should be relying only on server side computations for these keys). Signed-off-by: Bob Callaway <bcallaway@google.com>
Signed-off-by: Bob Callaway <bcallaway@google.com>
Codecov Report
@@ Coverage Diff @@
## main #967 +/- ##
==========================================
- Coverage 48.20% 48.06% -0.14%
==========================================
Files 61 61
Lines 5383 5413 +30
==========================================
+ Hits 2595 2602 +7
- Misses 2506 2528 +22
- Partials 282 283 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
dlorenc
approved these changes
Aug 11, 2022
asraa
approved these changes
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that the server-side values used by
IndexKeys()are computed during validation time rather than deferring it to when the indices are requested. This also ensures that client-provided values for these digests are not used when computing the list of indices.Fixes #854