Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolves sigstore/community#121 #1060

Closed
wants to merge 1 commit into from
Closed

Resolves sigstore/community#121 #1060

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,13 @@ name: CI-Container-Build
on:
workflow_dispatch:
push:
paths:
- '**'
- '!**.md'
- '!**.txt'
- '!images/**'
- '!LICENSE'
- 'tests/**'
branches:
- main
- release-*
Expand Down
14 changes: 14 additions & 0 deletions .github/workflows/codeql-analysis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,23 @@ name: CodeQL
on:
push:
branches: [ main ]
paths:
- '**'
- '!**.md'
- '!**.txt'
- '!images/**'
- '!LICENSE'
- 'tests/**'
pull_request:
# The branches below must be a subset of the branches above
branches: [ main ]
paths:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not good because this job is required and then this will never run or skipped and will be pending in the github status

I think for everything we should use the dorny/paths-filter

      - uses: dorny/paths-filter@v2
        id: filter
        with:
          filters: |
            terraform:
              - 'tests/**'

we will need to check if the syntax - '!images/**' works with this

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain more the first part: "will never run or skipped" ?

Also, dorny/paths-filter seems to handle the syntax !images/** in another way:

  • Define the filters (paths that can trigger the job or a step in a workflow).
  • Use if statement to choose if you want to trigger the job or not, based on the existence of the file or not.

- '**'
- '!**.md'
- '!**.txt'
- '!images/**'
- '!LICENSE'
- 'tests/**'
schedule:
- cron: '45 10 * * 1'

Expand Down
7 changes: 7 additions & 0 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,13 @@ name: CI

on:
push:
paths:
- '**'
- '!**.md'
- '!**.txt'
- '!images/**'
- '!LICENSE'
- 'tests/**'
branches: [ main ]
pull_request:
branches: [ main ]
Expand Down
7 changes: 7 additions & 0 deletions .github/workflows/validate-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,13 @@ name: CI-Validate-Release-Job

on:
push:
paths:
- '**'
- '!**.md'
- '!**.txt'
- '!images/**'
- '!LICENSE'
- 'tests/**'
branches:
- main
- release-*
Expand Down
7 changes: 7 additions & 0 deletions .github/workflows/verify.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,13 @@ name: Verify

on:
push:
paths:
- '**'
- '!**.md'
- '!**.txt'
- '!images/**'
- '!LICENSE'
- 'tests/**'
branches:
- main
pull_request:
Expand Down