remove /api/v1/version endpoint #1022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bob Callaway <bcallaway@google.com>
Codecov Report
@@ Coverage Diff @@
## main #1022 +/- ##
==========================================
- Coverage 41.44% 41.40% -0.04%
==========================================
Files 71 70 -1
Lines 6980 6972 -8
==========================================
- Hits 2893 2887 -6
+ Misses 3783 3779 -4
- Partials 304 306 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This was referenced Sep 1, 2022
priyawadhwa
approved these changes
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes the /api/v1/version endpoint in an effort to not disclose the server's operating version to malicious users. This is consistent with Fulcio where we also removed this endpoint.
Note there are some uses in sigstore/scaffolding, sigstore/sigstore-rs which we should get rid of as well.
Signed-off-by: Bob Callaway bcallaway@google.com