Don't unnecessarily extract uuid

Signed-off-by: Priya Wadhwa <priya@chainguard.dev>
sigstore · Aug 30, 2022 · aebe35f · aebe35f
1 parent 66eb52c
commit aebe35f
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/pkg/api/entries.go b/pkg/api/entries.go
@@ -338,11 +338,11 @@ func SearchLogQueryHandler(params entries.SearchLogQueryParams) middleware.Respo
 				resultPayload = append(resultPayload, logEntry)
 				continue
 			}
-			uuid, err := sharding.GetUUIDFromIDString(entryID)
-			if err != nil {
-				return handleRekorAPIError(params, http.StatusBadRequest, err, fmt.Sprintf("could not get UUID from ID string %v", entryID))
+			// At this point, check if we got a uuid instead of an EntryID, so search for the hash later
+			uuid := entryID
+			if err := sharding.ValidateUUID(uuid); err != nil {
+				return handleRekorAPIError(params, http.StatusBadRequest, err, fmt.Sprintf("validating uuid %s", uuid))
 			}
-			// If we couldn't get the entry, search for the hash later
 			hash, err := hex.DecodeString(uuid)
 			if err != nil {
 				return handleRekorAPIError(params, http.StatusBadRequest, err, malformedUUID)