First commit of the new bundle format. #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fredrik Skogman <kommendorkapten@github.com>
kommendorkapten
requested review from
bobcallaway,
haydentherapper and
znewman01
3 tasks
asraa
reviewed
Oct 21, 2022
Signed-off-by: Fredrik Skogman <kommendorkapten@github.com>
bobcallaway
reviewed
Oct 21, 2022
znewman01
previously approved these changes
Oct 21, 2022
and open a bunch of issues on this repo for discussion about specifics.
|
/wait til next week please, I'd like to take a look at this but need to do a couple GA things today |
Signed-off-by: Fredrik Skogman <kommendorkapten@github.com>
Co-authored-by: Hayden B <hblauzvern@gmail.com> Signed-off-by: Fredrik Skogman <kommendorkapten@github.com>
Co-authored-by: Hayden B <hblauzvern@gmail.com> Signed-off-by: Fredrik Skogman <kommendorkapten@github.com>
Co-authored-by: Hayden B <hblauzvern@gmail.com> Signed-off-by: Fredrik Skogman <kommendorkapten@github.com>
Use specific commit hash instead of branch name. Signed-off-by: Fredrik Skogman <kommendorkapten@github.com>
Signed-off-by: Fredrik Skogman <kommendorkapten@github.com>
Co-authored-by: Hayden B <hblauzvern@gmail.com> Signed-off-by: Fredrik Skogman <kommendorkapten@github.com>
Co-authored-by: Hayden B <hblauzvern@gmail.com> Signed-off-by: Fredrik Skogman <kommendorkapten@github.com>
Co-authored-by: Hayden B <hblauzvern@gmail.com> Signed-off-by: Fredrik Skogman <kommendorkapten@github.com>
Co-authored-by: Hayden B <hblauzvern@gmail.com> Signed-off-by: Fredrik Skogman <kommendorkapten@github.com>
Co-authored-by: Hayden B <hblauzvern@gmail.com> Signed-off-by: Fredrik Skogman <kommendorkapten@github.com>
Signed-off-by: Fredrik Skogman <kommendorkapten@github.com>
bobcallaway
reviewed
Oct 27, 2022
bobcallaway
reviewed
Oct 27, 2022
Signed-off-by: Fredrik Skogman <kommendorkapten@github.com>
asraa
reviewed
Oct 27, 2022
Signed-off-by: Fredrik Skogman <kommendorkapten@github.com>
|
All comments are addressed now (some will be added as issue this week). Are we ready to merge now? |
znewman01
approved these changes
Oct 31, 2022
|
THANKS A LOT ❤️ everyone! I will follow up this week and add a few issues to cover some of the discussions that was to big for this PR 📝 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Fredrik Skogman kommendorkapten@github.com
This is the unmodified files from this PR sigstore/cosign#2204.
This is PR is minimized now, it only contains the raw protobuf files, no tooling etc. As I would like to have the protobuf files merged sooner rather than later I will follow up with a new PR that adds tooling around this.
cc: @bobcallaway @haydentherapper @znewman01