Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backfillredis helm chart. #398

Merged
merged 2 commits into from Nov 14, 2022
Merged

Backfillredis helm chart. #398

merged 2 commits into from Nov 14, 2022

Conversation

vaikas
Copy link
Contributor

@vaikas vaikas commented Nov 2, 2022

Signed-off-by: Ville Aikas vaikas@chainguard.dev

Description of the change

We need to run a job in the cluster to backfill redis. The code is here:
sigstore/rekor#1163

So this wraps it in a helm chart

Existing or Associated Issue(s)

Additional Information

Checklist

  • Chart version bumped in Chart.yaml according to semver. Where applicable, update and bump the versions in any associated umbrella chart
  • Variables are documented in the values.yaml and added to the README.md. The helm-docs utility can be used to generate the necessary content. Use helm-docs --dry-run to preview the content.
  • JSON Schema generated.
  • List tests pass for Chart using the Chart Testing tool and the ct lint command.

@haydentherapper
Copy link
Contributor

Just to check, can we get the logs for the job once it finishes? Do we need to configure anything to prevent something else from coming along and scheduling another job and removing the logs?

@vaikas
Copy link
Contributor Author

vaikas commented Nov 3, 2022

Just to check, can we get the logs for the job once it finishes? Do we need to configure anything to prevent something else from coming along and scheduling another job and removing the logs?

Yes, the job runs, and if it fails, it will retry up to 6 times by default. If it succeeds, yay! We'll have logs available from the normal console / kubectl way.

@vaikas vaikas changed the title [WIP] Start of the backfillredis helm chart. Start of the backfillredis helm chart. Nov 3, 2022
haydentherapper
haydentherapper previously approved these changes Nov 3, 2022
Copy link
Contributor

@haydentherapper haydentherapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vaikas vaikas changed the title Start of the backfillredis helm chart. [WIP] Start of the backfillredis helm chart. Nov 3, 2022
k4leung4
k4leung4 previously approved these changes Nov 3, 2022
Copy link
Collaborator

@k4leung4 k4leung4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good
thanks

@vaikas vaikas changed the title [WIP] Start of the backfillredis helm chart. Start of the backfillredis helm chart. Nov 14, 2022
@vaikas vaikas changed the title Start of the backfillredis helm chart. Backfillredis helm chart. Nov 14, 2022
@vaikas vaikas force-pushed the backfill-job branch 2 times, most recently from 640f937 to f1fcbdc Compare November 14, 2022 19:00
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
@vaikas
Copy link
Contributor Author

vaikas commented Nov 14, 2022

Also note that when I ran

helm-docs -g charts/rekor

it picked up the changes from #409 to README. I didn't actually change them in this PR.

@vaikas vaikas merged commit c5b9eed into sigstore:main Nov 14, 2022
@vaikas vaikas deleted the backfill-job branch November 14, 2022 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants