fix example to explicitly set port for gRPC call (#732)

* fix example to explicitly set port for gRPC call Signed-off-by: Bob Callaway <bcallaway@google.com> * switch from RSA to ECDSA Signed-off-by: Bob Callaway <bcallaway@google.com>
sigstore · Aug 10, 2022 · 9c0a2e7 · 9c0a2e7
1 parent 7764cdb
commit 9c0a2e7
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/examples/request-certificate/.gitignore b/examples/request-certificate/.gitignore
@@ -0,0 +1 @@
+request-certificate
diff --git a/examples/request-certificate/main.go b/examples/request-certificate/main.go
@@ -43,7 +43,7 @@ var (
 )
 
 // Some of this is just ripped from cosign
-func GetCert(signer *signature.RSAPKCS1v15SignerVerifier, fc fulciopb.CAClient, oidcIssuer string, oidcClientID string) (*fulciopb.SigningCertificate, error) {
+func GetCert(signer *signature.ECDSASignerVerifier, fc fulciopb.CAClient, oidcIssuer string, oidcClientID string) (*fulciopb.SigningCertificate, error) {
 
 	tok, err := oauthflow.OIDConnect(oidcIssuer, oidcClientID, "", "", oauthflow.DefaultIDTokenGetter)
 	if err != nil {
@@ -85,18 +85,21 @@ func NewClient(fulcioURL string) (fulciopb.CAClient, error) {
 		return nil, err
 	}
 	dialOpt := grpc.WithTransportCredentials(insecure.NewCredentials())
+	hostWithPort := fmt.Sprintf("%s:80", fulcioServer.Host)
 	if fulcioServer.Scheme == "https" {
 		dialOpt = grpc.WithTransportCredentials(credentials.NewTLS(&tls.Config{}))
+		hostWithPort = fmt.Sprintf("%s:443", fulcioServer.Host)
 	}
-	conn, err := grpc.Dial(fulcioServer.Host, dialOpt)
+
+	conn, err := grpc.Dial(hostWithPort, dialOpt)
 	if err != nil {
 		return nil, err
 	}
 	return fulciopb.NewCAClient(conn), nil
 }
 
 func main() {
-	signer, _, err := signature.NewDefaultRSAPKCS1v15SignerVerifier()
+	signer, _, err := signature.NewDefaultECDSASignerVerifier()
 	if err != nil {
 		log.Fatal(err)
 	}