Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PayloadProvider interface to decouple AttestationToPayloadJSON from oci.Signature interface #3693

Merged
merged 2 commits into from May 13, 2024

Conversation

codysoyland
Copy link
Member

I'm working on Policy Controller and need to use AttestationToPayloadJSON without having an entire oci.Signature. Since this func only needs the Payload, I added a small PayloadProvider interface containing only the Payload func, which preserves backwards compatibility while decoupling the oci.Signature interface.

Signed-off-by: Cody Soyland codysoyland@github.com

Summary

Release Note

Documentation

…om oci.Signature interface

Signed-off-by: Cody Soyland <codysoyland@github.com>
Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.60%. Comparing base (2ef6022) to head (ed091e8).
Report is 102 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3693      +/-   ##
==========================================
+ Coverage   40.10%   40.60%   +0.49%     
==========================================
  Files         155      157       +2     
  Lines       10044    10157     +113     
==========================================
+ Hits         4028     4124      +96     
- Misses       5530     5535       +5     
- Partials      486      498      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Cody Soyland <codysoyland@github.com>
Copy link
Contributor

@haydentherapper haydentherapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@haydentherapper haydentherapper merged commit d2766d8 into sigstore:main May 13, 2024
24 checks passed
@github-actions github-actions bot added this to the v2.3.0 milestone May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants