Support Gitpod workspaces #3601
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Edward Brough <1690260+ChevronTango@users.noreply.github.com>
Signed-off-by: Edward Brough <edward.brough@gmail.com>
ChevronTango
force-pushed
the
feature/gitpod
branch
from
7a3476a
to
f46de86
Compare
cmurphy
reviewed
Apr 30, 2024
| @@ -0,0 +1,18 @@ | |||
| // | |||
| // Copyright 2021 The Sigstore Authors. | |||
There was a problem hiding this comment.
Suggested change
| // Copyright 2021 The Sigstore Authors. | |
| // Copyright 2024 The Sigstore Authors. |
| @@ -0,0 +1,72 @@ | |||
| // | |||
| // Copyright 2021 The Sigstore Authors. | |||
There was a problem hiding this comment.
Suggested change
| // Copyright 2021 The Sigstore Authors. | |
| // Copyright 2024 The Sigstore Authors. |
| ) | ||
|
|
||
| func init() { | ||
| providers.Register("filesystem", &gitpod{}) |
There was a problem hiding this comment.
Suggested change
| providers.Register("filesystem", &gitpod{}) | |
| providers.Register("gitpod", &gitpod{}) |
| // Check we are in a Gitpod Workspace | ||
| if env.Getenv(env.VariableGitpodWorkspaceId) != "" { | ||
|
|
||
| //Check we are able to generate tokens with a verified email address |
There was a problem hiding this comment.
Suggested change
| //Check we are able to generate tokens with a verified email address | |
| // Check we are able to generate tokens with a verified email address |
(golangci-lint run will catch this)
| if env.Getenv(env.VariableGitpodWorkspaceId) != "" { | ||
|
|
||
| //Check we are able to generate tokens with a verified email address | ||
| output, err := exec.Command("gp", "idp", "token", "--audience", "example.org", "--decode").Output() |
There was a problem hiding this comment.
How necessary is this check, if the workspace variable is known to be set? The github provider, for example, only bothers to check the variable.
Is there a timeout option for this command?
All the providers are looped through when a new signer is created, so if this command doesn't exit quickly when not enabled, it will stall keyless signing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2997
Summary
This PR adds a provider that, when run from within a Gitpod workspace, retrieves a token automatically from the command line, which means users do not have to do any additional auth checks or config.
This PR was previously open as #2998 however work on Gitpod's end stalled and it took some time before changes were implemented that made this viable. These updates mean some, though not all, tokens can now be used with Sigstore, and Gitpod are correctly populating the
email_verifiedfield as required by Fulcio. Part of the logic of this PR has been changed to make sure we only send through tokens if they have this field and will be valid.Release Note
Documentation