Add common UI library for confirmation prompts. #2572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2572 +/- ##
==========================================
+ Coverage 30.15% 30.65% +0.49%
==========================================
Files 141 144 +3
Lines 8688 8723 +35
==========================================
+ Hits 2620 2674 +54
+ Misses 5684 5665 -19
Partials 384 384
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
znewman01
force-pushed
the
uilib
branch
2 times, most recently
from
518901f
to
19413d9
Compare
dlorenc
previously approved these changes
Dec 28, 2022
cpanato
previously approved these changes
Dec 29, 2022
This library: - Is testable. - Is consistent across the CLI. Related to (does not fix) sigstore#2296 and sigstore#2204. Signed-off-by: Zachary Newman <zjn@chainguard.dev>
|
Rebased! |
cpanato
approved these changes
Jan 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This library:
Related to (does not fix) #2510, #2296 and #2204.
Summary
Release Note
NONE
Documentation
N/A (though eventually we want to document common conventions for users).