Update warning when users sign images by tag. #2313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2313 +/- ##
==========================================
- Coverage 30.06% 30.05% -0.02%
==========================================
Files 131 131
Lines 8062 8066 +4
==========================================
Hits 2424 2424
- Misses 5314 5318 +4
Partials 324 324
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
priyawadhwa
previously approved these changes
Oct 5, 2022
|
See #2314 for lint. Should be fixed once that's merged and I rebase |
znewman01
force-pushed
the
message
branch
3 times, most recently
from
aaf38ee
to
1890cc5
Compare
hectorj2f
previously approved these changes
Oct 13, 2022
|
Newest change covers a lot of docs, and also adds some tests. |
hectorj2f
previously approved these changes
Oct 13, 2022
|
will close/reopen to see if that retriggers the ci, otherwise we will need some rebase |
See sigstore#2047. Signed-off-by: Zachary Newman <zjn@chainguard.dev>
Signed-off-by: Zachary Newman <zjn@chainguard.dev>
Also explicitly check for Digest being set, rather than Tag not being set. This doesn't actually make a difference because name.ParseReference just throws away the tag in such cases (maybe a bug), but it does make the intent clearer. Signed-off-by: Zachary Newman <zjn@chainguard.dev>
|
had to trigger tests 1 more time because the DCO check hung....fingers crossed! |
|
no substantive changes since hector last approved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2047.
Summary
Signing by tag can lead to race conditions and possibly insecure behavior, signing images other than those intended. This PR adds a warning when people do that (later, we'll make it an error.)
Release Note
Added warning when users refer to images to sign by tag (
example.com/image:latest). Instead, refer to images by digest (example.com/image@sha256:abcdef). This will be required in a future release.Documentation
No change to web docs; changes to CLI docs included.