Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check error on chain verification failure #2284

Merged
merged 2 commits into from Sep 27, 2022
Merged

Check error on chain verification failure #2284

merged 2 commits into from Sep 27, 2022

Commits on Sep 27, 2022

  1. Check error on chain verification failure 

    This fails certificate verification at the correct step.

err was declared in the else scope, but was not checked before exiting
the conditional. Therefore, if a failure occurred, we didn't return
an error. However, later in the code, in verifyBlob, we do an extra
check for if the certificate is valid. Because we haven't set the root
and intermediate certs yet, cert verification fails.

Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
    @haydentherapper
    haydentherapper committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    e61e47d View commit details
    Browse the repository at this point in the history

  2. Update error messages 

    Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
    @haydentherapper
    haydentherapper committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    2e58b74 View commit details
    Browse the repository at this point in the history